patch for installer

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

patch for installer

Michael Davey
Hi,

Here is a patch for the installer:

*  fix some typos and invalid html
*  additional permissions check - prevent 'My Pipeline' showing a
permissions error on new install

The patch was created from cvs head using 'cvs diff -u'

--
Michael


? install.patch
Index: 0welcome.php
===================================================================
RCS file: /cvsroot/vtigercrm/vtiger_crm/install/0welcome.php,v
retrieving revision 1.9
diff -u -r1.9 0welcome.php
--- 0welcome.php 18 Jul 2005 10:15:35 -0000 1.9
+++ 0welcome.php 2 Oct 2005 11:04:36 -0000
@@ -48,14 +48,14 @@
 <HTML>
 <HEAD>
 <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
-<title>vtiger CRM 4.2 Installer: Step 1</title>
+<title>vtiger CRM 4.2 Installer: Step 0</title>
 <link rel="stylesheet" href="install/install.css" type="text/css" />
 </head>
 <body leftMargin="0" topMargin="0" marginheight="0" marginwidth="0">
 <table width="75%" border="0" cellpadding="3" cellspacing="0" align="center" style="border-bottom: 1px dotted #CCCCCC;"><tbody>
   <tr>
       <td align="left"><a href="http://www.vtiger.com" target="_blank" title="vtiger CRM"><IMG alt="vtiger CRM" border="0" src="include/images/vtiger_crmlogo.gif"/></a></td>
-      <td align="right"><h2>Step 1 of 5</h2></td>
+      <td align="right"><h2>Step 0 of 5</h2></td>
       <td align="right"><IMG alt="vtiger CRM" border="0" src="include/images/spacer.gif" width="10" height="1"/></td>
     </tr>
 </tbody></table>
Index: 1checkSystem.php
===================================================================
RCS file: /cvsroot/vtigercrm/vtiger_crm/install/1checkSystem.php,v
retrieving revision 1.10
diff -u -r1.10 1checkSystem.php
--- 1checkSystem.php 14 Jul 2005 08:45:47 -0000 1.10
+++ 1checkSystem.php 2 Oct 2005 11:04:37 -0000
@@ -165,41 +165,43 @@
 
  <td align="right"><?php $php_version = phpversion(); echo (str_replace(".", "", $php_version) < "420") ? "<strong><font color=\"#FF0000\">Invalid version ($php_version) Installed</font></strong>" : "<strong><font color=\"#0066CC\">Version $php_version Installed</font></strong>"; ?></td>
 
-     </tr>
+ </tr>
  <tr>
  <td bgcolor="#EEEEEE"><strong>Database</strong></td>
 
          <td align="right"><?php echo function_exists('mysql_connect')?"<strong><font color=\"#0066CC\">Available</font></strong>":"<strong><font color=\"#FF0000\">Not Available</font></strong>";?></td>
 
-    </tr>
+ </tr>
  <tr>
  <td bgcolor="#EEEEEE"><strong>config.php</strong></td>
 
  <td align="right"><?php echo (is_writable('./config.php') || is_writable('.'))?"<strong><font color=\"#0066CC\">Writeable</font></strong>":"<strong><font color=\"#FF0000\">Not Writeable</font></strong>"; ?></td>
  </tr>
- <tr>
+ <tr>
     <td bgcolor="#EEEEEE"><strong>Cache Directory (cache/)</strong></td>
 
                     <td align="right"><?php echo (is_writable('./cache/'))?"<strong><font color=\"#0066CC\">Writeable</font></strong>":"<strong><font color=\"#FF0000\">Not Writeable</font></strong>"; ?></td>
-                 </tr>
+ </tr>
  <tr>
- <tr>
     <td bgcolor="#EEEEEE"><strong>Mail Merge Template Directory (test/wordtemplatedownload/)</strong></td>
 
                     <td align="right"><?php echo (is_writable('./test/wordtemplatedownload/'))?"<strong><font color=\"#0066CC\">Writeable</font></strong>":"<strong><font color=\"#FF0000\">Not Writeable<br> You might experience issues with the word template feature. You might visit the link for more details : <a href=\"http://www.vtiger.com/discussions/viewtopic.php?p=2200#2200\" target=\"_blank\">forums</a> </font></strong>"; ?></td>
-                 </tr>
+ </tr>
  <tr>
- <tr>
     <td bgcolor="#EEEEEE"><strong>Uploads Directory (test/upload/)</strong></td>
 
                     <td align="right"><?php echo (is_writable('./test/upload/'))?"<strong><font color=\"#0066CC\">Writeable</font></strong>":"<strong><font color=\"#FF0000\">Not Writeable <br>You might experience problems with the file attachments feature. You might visit the following link for more details : <a href=http://www.vtiger.com/forums/viewtopic.php?t=24&highlight=permission>attachment issue</a></font></strong>"; ?></td>
-                 </tr>
+ </tr>
+ <tr>
+                    <td bgcolor="#EEEEEE"><strong>Images Directory (cache/images/)</strong></td>
+
+                    <td align="right"><?php echo (is_writable('./cache/images/'))?"<strong><font color=\"#0066CC\">Writeable</font></strong>":"<strong><font color=\"#FF0000\">Not Writeable <br>You might experience problems with dynamic images such as 'My Pipeline'. You might visit the following link for more details : <a href=\"http://www.vtiger.com/discussions/viewtopic.php?t=371&highlight=jpgraph+cache+error\">JpGraph Error</a></font></strong>"; ?></td>
+ </tr>
  <tr>
- <tr>
     <td bgcolor="#EEEEEE"><strong>Email Templates Directory (modules/Emails/templates/)</strong></td>
 
                     <td align="right"><?php echo (is_writable('./modules/Emails/templates/'))?"<strong><font color=\"#0066CC\">Writeable</font></strong>":"<strong><font color=\"#FF0000\">Not Writeable. You might experience problems with the email templates feature. You might refer to the following link for more details :<a href= http://www.vtiger.com/forums/viewtopic.php?t=388&highlight=permission>email templates issue </a> </font></strong>"; ?></td>
-                 </tr>
+ </tr>
  <tr>
  <td bgcolor="#EEEEEE"><strong>GD graphics library version 2.0 or later</strong></td>
 
Index: 3confirmConfig.php
===================================================================
RCS file: /cvsroot/vtigercrm/vtiger_crm/install/3confirmConfig.php,v
retrieving revision 1.13
diff -u -r1.13 3confirmConfig.php
--- 3confirmConfig.php 16 Jul 2005 10:41:19 -0000 1.13
+++ 3confirmConfig.php 2 Oct 2005 11:04:38 -0000
@@ -308,7 +308,7 @@
           </tr>
   <tr>
  <td>
- <font color=brown><b><P>Error Message: Unable to connect to database Sever with the specified connection parameters. This may be due to the following reasons:<P>
+ <font color=brown><b><P>Error Message: Unable to connect to database server with the specified connection parameters. This may be due to the following reasons:<P>
 
  -  specified database user, password , hostname or port is invalid.<BR>
                         -  specified database user does not have access to connect to the database server from the host</b></font>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: patch for installer

jaguar-2
Hi Michael,

Thank you for the contribution you have made and also for correcting the typos. 

We have integrated this into the product.

Thanks & Regards,
Jaguar




----[hidden email] wrote ---- 

Hi,

Here is a patch for the installer:

*  fix some typos and invalid html
*  additional permissions check - prevent 'My Pipeline' showing a 
permissions error on new install

The patch was created from cvs head using 'cvs diff -u'

-- 
Michael

Loading...