[Vtigercrm-developers] Commit "protocol"

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[Vtigercrm-developers] Commit "protocol"

Alan Lord (News)
This is something that is really irritating me:

http://code.vtiger.com/vtiger/vtigercrm/commit/714f7af03585e11ff636402cb22e609284daafa1

Please see the changes and the title of this commit and the issue which
it references.

The changes affect more than this issue. There are modifications to
remove more of the "Follow/Star" functionality as well.

This one is actually quite small but during this development, the vtiger
devs have dropped some Humongous commits into the tree which bear only a
minimal resemblance to the description in the commit log.

As I have asked previously, please can you use the tools you have at
your disposal properly? It makes it incredibly difficult to identify
what changes fix what particular issue when you drop 70 or more file
changes which are un-related to the commit title.

TIA

Al

_______________________________________________
http://www.vtiger.com/
Reply | Threaded
Open this post in threaded view
|

Re: Commit "protocol"

Satish Dvnk
Hi Alan,

We make our best attempt to push the fix against the issue. But when a mass-merge is performed such change set cannot be separated.

Hopefully we will avoid such mass changes in future.

regards,
Satish.Dvnk


On Thu, May 25, 2017 at 12:49 PM, Alan Lord <[hidden email]> wrote:
This is something that is really irritating me:

http://code.vtiger.com/vtiger/vtigercrm/commit/714f7af03585e11ff636402cb22e609284daafa1

Please see the changes and the title of this commit and the issue which it references.

The changes affect more than this issue. There are modifications to remove more of the "Follow/Star" functionality as well.

This one is actually quite small but during this development, the vtiger devs have dropped some Humongous commits into the tree which bear only a minimal resemblance to the description in the commit log.

As I have asked previously, please can you use the tools you have at your disposal properly? It makes it incredibly difficult to identify what changes fix what particular issue when you drop 70 or more file changes which are un-related to the commit title.

TIA

Al

_______________________________________________
http://www.vtiger.com/


_______________________________________________
http://www.vtiger.com/