Patch for Unicode-ready AlphabeticalSearch();

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch for Unicode-ready AlphabeticalSearch();

Антоха
Hi all!

Here is my patch for AlphabeticalSearch function.

Improvements:
1. Alphabetical search bar values stored in /include/$lang.lang.php file and
can be easily localized or even freely modified.
2. AlphabeticalSearch function now work with multibyte (or multicharacter)
values. It allows to use UTF-8 (16?) encoding. Or to use multiletter links.

P.S. This is my first patch for vTiger CRM. Community comments (and
criticism:) are welcome.

_______________________________________________
This vtiger.com email is sponsored by Zoho Planner. Still scribbling down your To-Do's on bits of paper & palms of your hands? Try the AJAX enabled, personal organizer online, Zoho Planner for FREE instead! http://zohoplanner.com/?vt 

include_utils.php.diff (1K) Download Attachment
include_language_en_us.lang.php.diff (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Patch for Unicode-ready AlphabeticalSearch();

Mike Fedyk
Can you post it in unified diff format (diff -u)?

The patch looks good.  If you can use the template to produce the output
it would be even better.  I'll take it either way though.

Mike

Антоха wrote:

> Hi all!
>
> Here is my patch for AlphabeticalSearch function.
>
> Improvements:
> 1. Alphabetical search bar values stored in /include/$lang.lang.php file and
> can be easily localized or even freely modified.
> 2. AlphabeticalSearch function now work with multibyte (or multicharacter)
> values. It allows to use UTF-8 (16?) encoding. Or to use multiletter links.
>
> P.S. This is my first patch for vTiger CRM. Community comments (and
> criticism:) are welcome.
>  
> ------------------------------------------------------------------------
>
> _______________________________________________
> This vtiger.com email is sponsored by Zoho Planner. Still scribbling down your To-Do's on bits of paper & palms of your hands? Try the AJAX enabled, personal organizer online, Zoho Planner for FREE instead! http://zohoplanner.com/?vt 
_______________________________________________
This vtiger.com email is sponsored by Zoho Planner. Still scribbling down your To-Do's on bits of paper & palms of your hands? Try the AJAX enabled, personal organizer online, Zoho Planner for FREE instead! http://zohoplanner.com/?vt 
Reply | Threaded
Open this post in threaded view
|

Re: Patch for Unicode-readyAlphabeticalSearch();

Антоха
> Can you post it in unified diff format (diff -u)?
Yes. Here is "unified" version. ("context" value for diff -u is 3)

Previous version I made with wiki guide
http://www.vtiger.com/wiki/index.php/HowToGeneratePatchWithWinMerge.

> The patch looks good.  If you can use the template to produce
> the output it would be even better.
Currently I'am not familiar with template engine :( Maybe later..

>I'll take it either way though.
Thanks.

>
> Mike
>
> Антоха wrote:
> > Hi all!
> >
> > Here is my patch for AlphabeticalSearch function.
> >
> > Improvements:
> > 1. Alphabetical search bar values stored in /include/$lang.lang.php
> > file and can be easily localized or even freely modified.
> > 2. AlphabeticalSearch function now work with multibyte (or
> > multicharacter) values. It allows to use UTF-8 (16?)
> encoding. Or to use multiletter links.
> >
> > P.S. This is my first patch for vTiger CRM. Community comments (and
> > criticism:) are welcome.
> >  
> >
> ----------------------------------------------------------------------
> > --
> >
> > _______________________________________________
> > This vtiger.com email is sponsored by Zoho Planner. Still
> scribbling
> > down your To-Do's on bits of paper & palms of your hands?
> Try the AJAX
> > enabled, personal organizer online, Zoho Planner for FREE instead!
> > http://zohoplanner.com/?vt
> _______________________________________________
> This vtiger.com email is sponsored by Zoho Planner. Still
> scribbling down your To-Do's on bits of paper & palms of your
> hands? Try the AJAX enabled, personal organizer online, Zoho
> Planner for FREE instead! http://zohoplanner.com/?vt 
>

_______________________________________________
This vtiger.com email is sponsored by Zoho Planner. Still scribbling down your To-Do's on bits of paper & palms of your hands? Try the AJAX enabled, personal organizer online, Zoho Planner for FREE instead! http://zohoplanner.com/?vt 

include_utils.php.diff (1K) Download Attachment
include_language_en_us.lang.php.diff (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Patch for Unicode-readyAlphabeticalSearch();

Mike Fedyk
http://vtiger.fosslabs.com/cgi-bin/trac.cgi/changeset/4397

Next time, please create a new ticket and attach your patch there.

Thanks for the patch.

Mike

Anthony V. Scray wrote:

>> Can you post it in unified diff format (diff -u)?
>>    
> Yes. Here is "unified" version. ("context" value for diff -u is 3)
>
> Previous version I made with wiki guide
> http://www.vtiger.com/wiki/index.php/HowToGeneratePatchWithWinMerge.
>
>  
>> The patch looks good.  If you can use the template to produce
>> the output it would be even better.
>>    
> Currently I'am not familiar with template engine :( Maybe later..
>
>  
>> I'll take it either way though.
>>    
> Thanks.
>
>  
>> Mike
>>
>> Антоха wrote:
>>    
>>> Hi all!
>>>
>>> Here is my patch for AlphabeticalSearch function.
>>>
>>> Improvements:
>>> 1. Alphabetical search bar values stored in /include/$lang.lang.php
>>> file and can be easily localized or even freely modified.
>>> 2. AlphabeticalSearch function now work with multibyte (or
>>> multicharacter) values. It allows to use UTF-8 (16?)
>>>      
>> encoding. Or to use multiletter links.
>>    
>>> P.S. This is my first patch for vTiger CRM. Community comments (and
>>> criticism:) are welcome.
>>>  
>>>
>>>      
>> ----------------------------------------------------------------------
>>    
>>> --
>>>
>>> _______________________________________________
>>> This vtiger.com email is sponsored by Zoho Planner. Still
>>>      
>> scribbling
>>    
>>> down your To-Do's on bits of paper & palms of your hands?
>>>      
>> Try the AJAX
>>    
>>> enabled, personal organizer online, Zoho Planner for FREE instead!
>>> http://zohoplanner.com/?vt
>>>      
>> _______________________________________________
>> This vtiger.com email is sponsored by Zoho Planner. Still
>> scribbling down your To-Do's on bits of paper & palms of your
>> hands? Try the AJAX enabled, personal organizer online, Zoho
>> Planner for FREE instead! http://zohoplanner.com/?vt 
>>
>>    
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> This vtiger.com email is sponsored by Zoho Planner. Still scribbling down your To-Do's on bits of paper & palms of your hands? Try the AJAX enabled, personal organizer online, Zoho Planner for FREE instead! http://zohoplanner.com/?vt 
_______________________________________________
This vtiger.com email is sponsored by Zoho Planner. Still scribbling down your To-Do's on bits of paper & palms of your hands? Try the AJAX enabled, personal organizer online, Zoho Planner for FREE instead! http://zohoplanner.com/?vt